Skip to content

MaterialX: Connect geometry_thin_walled flag to <surface>#250

Merged
jstone-lucasfilm merged 4 commits intoAcademySoftwareFoundation:dev_1.1.1from
msuzuki-nvidia:main
May 27, 2025
Merged

MaterialX: Connect geometry_thin_walled flag to <surface>#250
jstone-lucasfilm merged 4 commits intoAcademySoftwareFoundation:dev_1.1.1from
msuzuki-nvidia:main

Conversation

@msuzuki-nvidia
Copy link
Copy Markdown
Contributor

Connect geometry_thin_walled flag to <surface>.

jstone-lucasfilm and others added 2 commits June 28, 2024 14:05
This changelist merges v1.1 development from dev_1.1 to main, in preparation for marking the release of OpenPBR v1.1.
@pablode
Copy link
Copy Markdown

pablode commented Mar 18, 2025

One note: the geometry_thin_walled input should probably also be uniform="true" as the surface input has this attribute.

@msuzuki-nvidia
Copy link
Copy Markdown
Contributor Author

Makes sense, updated.

@jstone-lucasfilm jstone-lucasfilm changed the title Connect geometry_thin_walled flag to <surface> MaterialX: Connect geometry_thin_walled flag to <surface> May 27, 2025
@jstone-lucasfilm jstone-lucasfilm changed the base branch from main to dev_1.1.1 May 27, 2025 18:01
@jstone-lucasfilm jstone-lucasfilm changed the base branch from dev_1.1.1 to main May 27, 2025 18:01
@jstone-lucasfilm jstone-lucasfilm changed the base branch from main to dev_1.1.1 May 27, 2025 18:02
Copy link
Copy Markdown
Member

@jstone-lucasfilm jstone-lucasfilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks @msuzuki-nvidia!

@jstone-lucasfilm jstone-lucasfilm merged commit 21356d9 into AcademySoftwareFoundation:dev_1.1.1 May 27, 2025
1 check passed
jstone-lucasfilm added a commit that referenced this pull request May 28, 2025
Connect `geometry_thin_walled` flag to `surface`.
@msuzuki-nvidia msuzuki-nvidia deleted the main branch November 7, 2025 19:50
jreichel-nvidia added a commit to jreichel-nvidia/MaterialX that referenced this pull request Jan 27, 2026
jstone-lucasfilm pushed a commit to AcademySoftwareFoundation/MaterialX that referenced this pull request Feb 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants